Merged
Conversation
casaroli
reviewed
Feb 24, 2026
| -o -name '*.yml' -o -name '*.awk' -o -name '*.conf' -o -name 'Kconfig*' \ | ||
| -o -name '.gitignore' -o -name '.gitmodules' -o -name '*.sh' \) \ | ||
| ! -name 'utlist.h' \ | ||
| ! -name 'CMakeCCompilerId.c' \ |
Contributor
There was a problem hiding this comment.
this file does not exist
Suggested change
| ! -name 'CMakeCCompilerId.c' \ |
casaroli
reviewed
Feb 24, 2026
| ! -name 'utlist.h' \ | ||
| ! -name 'CMakeCCompilerId.c' \ | ||
| ! -path './tests/Unity/*' \ | ||
| ! -path './build/*' \ |
Contributor
There was a problem hiding this comment.
Suggested change
| ! -path './build/*' \ |
Collaborator
Author
There was a problem hiding this comment.
I think we don't need to check build folder
Contributor
There was a problem hiding this comment.
There should be no build folder. What if the build folder is somewhere else?
casaroli
reviewed
Feb 24, 2026
casaroli
reviewed
Feb 24, 2026
.gitignore
Outdated
Comment on lines
+6
to
+9
| # These are some examples of commonly ignored file patterns. | ||
| # You should customize this list as applicable to your project. | ||
| # Learn more about .gitignore: | ||
| # https://www.atlassian.com/git/tutorials/saving-changes/gitignore |
Contributor
There was a problem hiding this comment.
nit: can we clean up this?
Suggested change
| # These are some examples of commonly ignored file patterns. | |
| # You should customize this list as applicable to your project. | |
| # Learn more about .gitignore: | |
| # https://www.atlassian.com/git/tutorials/saving-changes/gitignore |
casaroli
reviewed
Feb 24, 2026
Signed-off-by: SorinO <sorin.olari2@gmail.com>
Signed-off-by: SorinO <sorin.olari2@gmail.com>
Signed-off-by: SorinO <sorin.olari2@gmail.com>
Signed-off-by: SorinO <sorin.olari2@gmail.com>
SorinOlari
force-pushed
the
license_banner_check_config_files
branch
from
ee8a5c9 to
1c4ce52
Compare
Collaborator
|
lgtm |
kr-t
approved these changes
Feb 26, 2026
casaroli
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added license banner checker for following files:
Fixes issue # #133
Type of change
How Has This Been Tested?
Intentionally introduced errors in the license banner text to ensure the script detects them as expected.
Checklist: